gnodet commented on code in PR #13491:
URL: https://github.com/apache/maven/pull/13491#discussion_r4492528992
##########
apache-maven/src/assembly/component.xml:
##########
@@ -25,16 +25,22 @@ under the License.
<includes>
<include>org.apache.maven:maven-classworlds</include>
</includes>
- <!-- Preserve the legacy plexus-classworlds-*.jar file name for backward
compatibility:
- wrapper scripts, CI tooling, and IDEs that glob
boot/plexus-classworlds-*.jar continue
- to work without change after the internalization. -->
-
<outputFileNameMapping>plexus-classworlds-${artifact.version}.jar</outputFileNameMapping>
</dependencySet>
Review Comment:
Yes, intentional. The `outputFileNameMapping` was introduced in the same PR
that internalized plexus-classworlds as `maven-classworlds` — it preserved the
`plexus-classworlds-*.jar` filename as a backward-compat shim. This PR removes
that shim because: (1) `mvn` and `mvn.cmd` now glob `boot/*.jar` instead of
`boot/plexus-classworlds-*.jar`, so Maven itself is unaffected; (2) this is a
Maven 4-only change and the compat story for external tooling globs is
documented in the original PR description. The breaking change is intentional
and scoped to Maven 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
