slachiewicz opened a new pull request, #3568: URL: https://github.com/apache/maven-surefire/pull/3568
The toolchains example used `<version>8</version>`. A single version in `jdkToolchain` must equal the version in `toolchains.xml`, so it matches only an entry labelled exactly `8`. A JDK discovered by the toolchains plugin reports its full version, such as `1.8.0_504` or `17.0.20`, and is not matched. The example now uses `[1.8,1.9)`, and a short paragraph explains how single versions and the other elements (`vendor`) are matched, in the same words as the Guide to Using Toolchains on maven.apache.org. Checked with Maven 3.9.16's version classes: `[1.8,1.9)` and `[17,18)` match `1.8.0_504` and `17.0.20`; `8`, `1.8` and `17` do not. `mvn site` for maven-surefire-plugin renders the page; `apache-rat:check` passes. Reported in Martijn Dashorst's list of documentation discrepancies (item 42). #3516 edits the same paragraph; whichever is merged second needs a one-line rebase. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
