goutamadwant opened a new pull request, #13891:
URL: https://github.com/apache/maven/pull/13891
Follow-up to #13885, related to #13883. Targets `maven-3.10.x`.
The original shadowing fix is already merged. A custom `rootDirectory` that
refers to `${project.rootDirectory}` or `${pom.rootDirectory}` can still fail
interpolation because the recursion detector treats the custom property and the
built-in expression as the same key.
Track bare `rootDirectory` separately and retain prefix-aware cycle
detection for the other expressions. Tests cover model, user and system
aliases, early model consumers, genuine cycles and tracker reset in both
interpolators.
### Validation
- New regressions fail on unchanged current `maven-3.10.x`.
- `mvn -B -ntp verify`: 1,154 tests reported, 8 skipped, zero failures or
errors.
- Four focused Core IT cases pass with the fix; the explicit-root alias case
fails on the current upstream distribution. [Companion integration
tests](https://github.com/goutamadwant/maven/tree/29cb5e6764418ce6f46734e5cbb7ac57e6191b72/its/core-it-suite/src/test/resources/gh-13883-custom-root-directory).
- Full Core IT suite and hosted CI have not been run.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
