gnodet-bot commented on code in PR #1217:
URL:
https://github.com/apache/maven-plugin-tools/pull/1217#discussion_r4505381844
##########
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##########
@@ -82,6 +83,14 @@ public class PluginReport extends AbstractMavenReport {
@Parameter(defaultValue = "false", property = "maven.plugin.report.skip")
private boolean skip;
+ /**
+ * Set this to {@code false} to stop generating compatibility pages using
the legacy {@code -mojo.html} suffix.
+ *
+ * @since 4.0.0
+ */
+ @Parameter(defaultValue = "true", property =
"maven.plugin.report.generateLegacyMojoReports")
+ private boolean generateLegacyMojoReports;
Review Comment:
⚠️ **Missing IT for `generateLegacyMojoReports=false`**
This new parameter is never exercised with `false` in any integration test.
The ITs only run with the default (`true`), so the branch that suppresses
redirect file generation is completely untested.
Add an IT (e.g. `plugin-report-no-compat`) that sets this to `false` via
`invoker.properties` or plugin configuration, and verifies:
1. `{goal}-goal.html` exists.
2. `{goal}-mojo.html` does **not** exist (no redirect generated).
Without this, a regression in the flag's injection or the conditional guard
would go undetected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
