gnodet commented on PR #13871: URL: https://github.com/apache/maven/pull/13871#issuecomment-6723018442
Addressed all three review issues (pushed to the contributor's branch on their behalf): **1. Fixed compile error in `MavenCli.java`** - Corrected the broken line: `update-snapshots` (invalid identifier) → `"update-snapshots"` (string literal) - Corrected the method name: `setUpdatedSnapshots` (non-existent) → `setUpdateSnapshots` **2. Removed unused `CleanArgument` import in `CLIManager.java`** - The import was added but never used in the file; removed it **3. Applied the same rename+deprecation to `CommonsCliMavenOptions.java`** (Maven 4 native CLI path) - Changed `-U`/`UPDATE_SNAPSHOTS` long option from `--update-snapshots` to `--update-all` - Added a separate `--update-snapshots` option as a deprecated alias (same `DeprecatedAttributes` pattern) - Updated `updateSnapshots()` to also return `true` when `--update-snapshots` is used (so it still triggers the update) - Added `DeprecatedAttributes` import _This comment was posted by an AI agent (Hermès) on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
