michael-o commented on code in PR #732:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/732#discussion_r4510845282


##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java:
##########
@@ -921,13 +918,13 @@ private File resolveSiteDescriptor(
                 return siteDescriptor;
             }
             LOGGER.debug("No site descriptor found for '" + project.getId() + 
"' for locale '" + language
-                    + "', trying without language (default locale)...");
+                    + "', trying without locale...");

Review Comment:
   This is a bit confusing because we always have a locally technically, maybe 
"without explicit locale"? WDYT?



##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java:
##########
@@ -135,6 +135,15 @@ public class DefaultSiteTool implements SiteTool {
     @Inject
     protected SiteModelInheritanceAssembler assembler;
 
+    /** Creates the tool and logs the default locale it works with. */
+    public DefaultSiteTool() {
+        LOGGER.debug(
+                "Default locale: {} (system property {}={})",
+                SiteTool.DEFAULT_LOCALE.toString().isEmpty() ? "root" : 
SiteTool.DEFAULT_LOCALE,

Review Comment:
   I'd use "ROOT" not to confuse with a real locale.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to