desruisseaux commented on code in PR #422:
URL: https://github.com/apache/maven-archiver/pull/422#discussion_r4511431253
##########
src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java:
##########
@@ -276,24 +240,20 @@ private static String sanitizeManifestValue(String value)
{
* @param project {@link org.apache.maven.api.Project}
* @param config {@link ManifestConfiguration}
* @param entries the entries
- * @return {@link org.codehaus.plexus.archiver.jar.Manifest}
+ * @return {@link java.util.jar.Manifest}
* @throws MavenArchiverException exception
*/
protected Manifest getManifest(
Session session, Project project, ManifestConfiguration config,
Map<String, String> entries)
throws MavenArchiverException {
- try {
- return doGetManifest(session, project, config, entries);
- } catch (ManifestException e) {
- throw new MavenArchiverException("Unable to create manifest", e);
- }
+ return doGetManifest(session, project, config, entries);
}
protected Manifest doGetManifest(
Review Comment:
Seems a useless method now that its behaviour is strictly identical to
`getManifest` (the latter just invoke this method without any additional work).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]