arturobernalg opened a new pull request, #3583:
URL: https://github.com/apache/maven-surefire/pull/3583
A systemPropertyVariables entry whose value is nothing but
"${surefire.forkNumber}" never reaches Surefire's own placeholder replacement:
Maven's own property interpolation resolves a value that is a single ${...}
expression as a real Maven property first, finds none, and silently blanks it.
Prefixing the value with any literal character (the documented workaround)
avoids this, since it stops Maven from treating the whole value as one
expression - but that only works by accident and changes the resulting string.
"@{...}" is Maven's own delayed-resolution syntax, meant for exactly this:
it survives Maven's property interpolation unresolved, so Surefire's
replacement still sees the placeholder text. Recognize "@{surefire.forkNumber}"
and "@{surefire.threadNumber}" in replaceThreadNumberPlaceholders() alongside
the existing "${...}" forms, which argLine and systemPropertyVariables both go
through.
This is additive: the existing "${...}" placeholders are unchanged, and no
test or documented behavior relies on "@{...}" text passing through unexpanded.
Verified against a built maven-surefire-plugin 3.6.2-SNAPSHOT: with
forkCount=2, a plain "${surefire.forkNumber}" system property is still blank
(unchanged, documented), while "@{surefire.forkNumber}" now resolves to the
fork number.
Fixes #1493
---
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](https://www.apache.org/licenses/LICENSE-2.0)
check one of the following:
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
- [x] I hereby declare that I have filed an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]