ascheman commented on PR #996:
URL: https://github.com/apache/maven-enforcer/pull/996#issuecomment-6738376126

   Superseded by #1080, which carries these same commits plus the follow-ups 
that came out of this discussion. The description here had drifted a long way 
from what the branch actually does, so a clean one seemed more useful to a 
reviewer than another round of edits.
   
   Nothing in this thread is lost — it stays readable, and the new description 
links back to it:
   
   - Bukama's question about the Java 8 guard on a Moditect-style build. The 
guard did hold, but the question uncovered a different bug: the rules never 
inspected the packaged artifact, so `requireExplicitModules` failed any project 
whose descriptor is injected after compilation, on every JDK. All three rules 
now fall back to the artifact, and following the same thread turned up a second 
problem — bound to the `enforce` goal's default `validate` phase the rules 
found nothing and reported success, a check passing without having checked 
anything. They now warn instead.
   - elharo's review points on visibility, defensive copies, javadoc and 
wording, and the question whether these rules are needed on a Java 8 baseline, 
which the Java 9+ runtime guard answers.
   - scordio's successful test run against the AssertJ build.
   - The Copilot findings on non-deterministic iteration order and null-valued 
list parameters.
   
   Thanks for all of it. Further review welcome on #1080.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to