gnodet-bot commented on code in PR #13919:
URL: https://github.com/apache/maven/pull/13919#discussion_r4516041614


##########
maven-core/src/main/java/org/apache/maven/api/services/MessageBuilderFactory.java:
##########
@@ -16,14 +16,19 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.maven.message;
+package org.apache.maven.api.services;
+
+import org.apache.maven.api.Service;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
 
 /**
  * A factory for {@link MessageBuilder}.
  *
- * @since 3.10.0
+ * @since 4.0.0

Review Comment:
   💡 **`@since` tag**: Same as `MessageBuilder` — this type first ships in 
Maven 3.10.1:
   
   ```suggestion
    * @since 3.10.1
   ```



##########
maven-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api;
+
+/**
+ * Configuration constants.
+ * <p>
+ * Maven 3 carries only the style names of the Maven 4 class, for {@link 
org.apache.maven.api.services.MessageBuilder}.
+ */
+public final class Constants {

Review Comment:
   💡 **Missing `@since` on class**: The `Constants` class has `@since 4.0.0` on 
each field's Javadoc, but the class itself lacks a class-level `@since` tag. As 
a new public API class, it should have one:
   
   ```suggestion
   /**
    * Configuration constants.
    * <p>
    * Maven 3 carries only the style names of the Maven 4 class, for {@link 
org.apache.maven.api.services.MessageBuilder}.
    *
    * @since 3.10.1
    */
   public final class Constants {
   ```



##########
maven-core/src/main/java/org/apache/maven/api/services/MessageBuilder.java:
##########
@@ -16,12 +16,15 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.maven.message;
+package org.apache.maven.api.services;
+
+import org.apache.maven.api.Constants;
+import org.apache.maven.api.annotations.Nonnull;
 
 /**
  * Message builder that supports configurable styling.
  *
- * @since 3.10.0
+ * @since 4.0.0

Review Comment:
   💡 **`@since` tag**: This type first ships in Maven 3.10.1 (backport branch), 
not 4.0.0. The convention is to document the first version where users 
encounter the API:
   
   ```suggestion
    * @since 3.10.1
   ```
   
   `@since 4.0.0` correctly identifies the Maven 4 origin, but on a 3.10.x 
backport the tag should reflect when it first becomes available to users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to