arturobernalg opened a new pull request, #161: URL: https://github.com/apache/maven-dependency-tree/pull/161
DependencyNode implementations are not required to implement value-based equality, and DefaultDependencyNode does not override equals()/hashCode(), so AncestorOrSelfDependencyNodeFilter's reliance on DependencyNode#equals silently falls back to identity comparison. This breaks the filter whenever it is tested against a tree that was rebuilt from, but no longer shares node instances with, the tree it was built against (e.g. via BuildingDependencyNodeVisitor, a pattern used by consumers such as maven-dependency-plugin). Fixes #132 To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
