gnodet commented on PR #13941: URL: https://github.com/apache/maven/pull/13941#issuecomment-6762218149
The core auto-discovery feature (SPI-based `Listener` registration at session init) was already implemented and merged in #13701. I've updated the PR description to reflect what this PR actually adds on top of that: 1. **Defensive `LookupException` guard** — #13701's `lookupList()` call in `AbstractSession.getListeners()` was unguarded. This wraps it in `try/catch (LookupException)` so session initialization doesn't blow up in environments where the DI container isn't fully wired. 2. **Two additional tests in `EventSpyImplTest`** — complementing the four unit tests already added by #13701 in `MavenRepositoryListenerTest`. 3. **Javadoc additions** — extra detail on the exception-swallowing contract on `Listener#onEvent()` itself. The PR is worth merging for the defensive guard and the extra test coverage. Please also note that this closes #13805 (not #13520, which is a separate issue about a dedicated `RepositoryListener` SPI for IDE embedders). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
