simono commented on PR #435: URL: https://github.com/apache/maven-wrapper/pull/435#issuecomment-6774731292
> FWIW the jar flavor: [#476](https://github.com/apache/maven-wrapper/pull/476) Nice, that's a cleaner end state, and it fixes #425 too since the .zip is always what gets downloaded and checked. One thing I noticed in #476: only `bin/$MVN_CMD` gets `chmod +x`. With `mvnwDebug`, `MVN_CMD=mvnDebug`, and Maven 3.9's `bin/mvnDebug` runs `"`dirname "$0"`/mvn"`, which `jar xf` leaves as `-rw-r--r--`, so it fails with permission denied. `chmod +x "$TMP_DOWNLOAD_DIR/$actualDistributionDir"/bin/*` would cover it. How about merging this one as the minimal fix for the next release, with #476 following as the rework? It removes this check along with the fallback anyway. Happy to close this one instead if you'd rather go straight to #476. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
