gnodet-bot commented on code in PR #13947:
URL: https://github.com/apache/maven/pull/13947#discussion_r4539081576


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -847,11 +847,13 @@ protected void configure() {
         }
     }
 
-    private List<CoreExtension> readCoreExtensionsDescriptor(Path 
extensionsFile)
-            throws IOException, XmlPullParserException {
+    List<CoreExtension> readCoreExtensionsDescriptor(Path extensionsFile) 
throws IOException, XmlPullParserException {
         CoreExtensionsXpp3Reader parser = new CoreExtensionsXpp3Reader();

Review Comment:
   🔧 **Nit:** `throws XmlPullParserException` on this method signature is now 
dead — the catch block below wraps every `XmlPullParserException` into an 
`IOException`, so the checked exception can never escape the method. Consider 
removing it to avoid misleading callers.
   
   ```suggestion
       List<CoreExtension> readCoreExtensionsDescriptor(Path extensionsFile) 
throws IOException {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to