gnodet-bot commented on code in PR #13832: URL: https://github.com/apache/maven/pull/13832#discussion_r4548215230
########## impl/maven-logging-slf4j/src/main/java/org/apache/maven/logging/slf4j/MavenSimpleLogger.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.logging.slf4j; + +import java.util.Arrays; +import java.util.Map; + +import org.apache.maven.api.MonotonicClock; +import org.apache.maven.api.logging.LogLevel; +import org.apache.maven.api.logging.LogSink; +import org.apache.maven.api.logging.LoggerManager; +import org.apache.maven.logging.impl.DefaultLogEvent; +import org.apache.maven.logging.impl.DefaultLoggerManager; +import org.slf4j.Marker; +import org.slf4j.event.Level; +import org.slf4j.helpers.LegacyAbstractLogger; +import org.slf4j.spi.LocationAwareLogger; + +/** + * Thin SLF4J logger that dispatches events to the Maven unified logging API + * via {@link LoggerManager}. Level checks are delegated to + * {@link DefaultLoggerManager}; formatting is deferred to the {@link LogSink}. + * + * @since 3.5.0 Review Comment: ⚠️ **Persistent finding — wrong `@since` tag.** `org.apache.maven.logging.slf4j.MavenSimpleLogger` is a brand-new class in a new package/module introduced by this PR — it is not the old `org.apache.maven.slf4j.MavenSimpleLogger` (which was indeed `@since 3.5.0`). The `@since` tag must reflect when this new class is first available to users. ```suggestion * @since 4.2.0 ``` ########## impl/maven-logging-slf4j/src/main/java/org/apache/maven/logging/slf4j/MavenLoggerFactory.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.logging.slf4j; + +import java.util.Objects; +import java.util.WeakHashMap; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; + +import org.apache.maven.api.logging.LoggerManager; +import org.apache.maven.logging.impl.DefaultLoggerManager; +import org.slf4j.ILoggerFactory; +import org.slf4j.Logger; + +/** + * LogFactory for Maven which creates SLF4J loggers that delegate level checks + * and severity recording to the shared {@link DefaultLoggerManager}. + */ Review Comment: ⚠️ **Persistent finding — missing `@since` tag.** `MavenLoggerFactory` is a new public class in a new module. API Javadoc convention requires `@since` on every new public type. ```suggestion /** * LogFactory for Maven which creates SLF4J loggers that delegate level checks * and severity recording to the shared {@link DefaultLoggerManager}. * * @since 4.2.0 */ ``` ########## impl/maven-logging-jul/src/test/java/org/apache/maven/logging/jul/MavenJulHandlerTest.java: ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.logging.jul; + +import java.util.List; +import java.util.concurrent.atomic.AtomicReference; +import java.util.logging.Level; +import java.util.logging.LogRecord; + +import org.apache.maven.api.logging.LogEvent; +import org.apache.maven.api.logging.LogLevel; +import org.apache.maven.api.logging.LogSink; +import org.apache.maven.logging.impl.DefaultLoggerManager; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; + +@Timeout(10) +class MavenJulHandlerTest { + + private DefaultLoggerManager testManager; + + @BeforeEach + void installTestManager() { + testManager = new DefaultLoggerManager(); + testManager.setRootLoggerLevel(LogLevel.TRACE); + testManager.install(); + } + + @AfterEach + void clearTestManager() { + testManager.uninstall(); + testManager = null; + } + + @ParameterizedTest(name = "JUL {0} -> LogLevel.{1}") + @CsvSource({ + "FINEST, TRACE", + "FINER, DEBUG", + "FINE, DEBUG", + "CONFIG, INFO", + "INFO, INFO", + "WARNING, WARN", + "SEVERE, ERROR", + }) + void julLevelMapsToCorrectLogLevel(String julLevelName, String expectedLogLevel) { + Level julLevel = Level.parse(julLevelName); + LogLevel actual = MavenJulHandler.julLevelToLogLevel(julLevel); + assertEquals(LogLevel.valueOf(expectedLogLevel), actual); + } + + @Test + void finestMapsToTrace() { + assertEquals(LogLevel.TRACE, MavenJulHandler.julLevelToLogLevel(Level.FINEST)); + } + + @Test + void configMapsToInfo() { + assertEquals(LogLevel.INFO, MavenJulHandler.julLevelToLogLevel(Level.CONFIG)); + } + + @Test + void publishIsReentrantSafe() { + MavenJulHandler handler = new MavenJulHandler(); + LogRecord record = new LogRecord(Level.INFO, "nested"); + + MavenJulHandler.setInPublishForTest(true); + try { + handler.publish(record); + } finally { + MavenJulHandler.setInPublishForTest(false); + } + } Review Comment: ⚠️ **Persistent finding — missing happy-path assertion.** `publishIsReentrantSafe()` only verifies that a re-entrant `publish()` does not throw. It never asserts that a *normal* (non-reentrant) `publish()` actually delivers the event to a sink. The re-entrancy guard is only meaningful if the happy path works — the test should validate both. ```suggestion void publishIsReentrantSafe() { // Happy path: a normal (non-reentrant) publish must deliver the event to the sink AtomicReference<LogEvent> captured = new AtomicReference<>(); testManager.setLogSink(event -> captured.set(event)); MavenJulHandler handler = new MavenJulHandler(); LogRecord normal = new LogRecord(Level.INFO, "normal"); handler.publish(normal); assertNotNull(captured.get(), "normal publish must deliver the event to the sink"); // Guard path: a re-entrant publish must be suppressed (no second event, no exception) captured.set(null); LogRecord record = new LogRecord(Level.INFO, "nested"); MavenJulHandler.setInPublishForTest(true); try { handler.publish(record); } finally { MavenJulHandler.setInPublishForTest(false); } assertNull(captured.get(), "re-entrant publish must be suppressed"); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
