gnodet-bot commented on code in PR #12377:
URL: https://github.com/apache/maven/pull/12377#discussion_r4550886298
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultProfileSelector.java:
##########
@@ -140,4 +141,8 @@ private boolean isActiveByDefault(Profile profile) {
Activation activation = profile.getActivation();
return activation != null && activation.isActiveByDefault();
}
+
+ private boolean isFromPom(Profile profile) {
+ return ProfileSourceDetector.isFromPom(profile);
Review Comment:
🔁 **Nit (third mention):** This wrapper uses no instance state — it should
be `private static` for consistency with
`ConditionProfileActivator.isFromPom()` (which is already `private static`).
```suggestion
private static boolean isFromPom(Profile profile) {
```
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/PropertyProfileActivator.java:
##########
@@ -161,4 +161,13 @@ public boolean presentInConfig(Profile profile,
ProfileActivationContext context
return property != null;
}
+
+ /**
+ * Determines whether the given profile originates from a POM file.
+ *
+ * @see ProfileSourceDetector#isFromPom(Profile)
+ */
+ private boolean isFromPom(Profile profile) {
Review Comment:
🔁 **Nit (third mention):** Same as `DefaultProfileSelector` — should be
`private static` for consistency with `ConditionProfileActivator.isFromPom()`.
```suggestion
private static boolean isFromPom(Profile profile) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
