gnodet-bot commented on code in PR #13962:
URL: https://github.com/apache/maven/pull/13962#discussion_r4554299935


##########
impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanCreatorTest.java:
##########
@@ -502,7 +502,8 @@ void testReactorPluginPreCompilePhase() {
         // "initialize" ends well before "ready" in the lifecycle.
         DefaultLifecycleRegistry lifecycles = new 
DefaultLifecycleRegistry(Collections.emptyList());
         BuildPlanExecutor.BuildContext context =
-                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles).new BuildContext();
+                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, null)

Review Comment:
   🔧 **Nit:** The sibling call site at line 231 in this file and 
`BuildPlanExecutorTest.java` both pass `Collections.emptyList()` for the 
`lifecycleProcessors` parameter. Using `null` works (the constructor 
null-guards it) but is inconsistent with the other usages.
   
   ```suggestion
                   new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, Collections.emptyList())
   ```



##########
impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanCreatorTest.java:
##########
@@ -583,7 +584,8 @@ void 
testReactorPluginWithLibraryDependencyPreCompilePhase() {
 
         DefaultLifecycleRegistry lifecycles = new 
DefaultLifecycleRegistry(Collections.emptyList());
         BuildPlanExecutor.BuildContext context =
-                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles).new BuildContext();
+                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, null)

Review Comment:
   🔧 **Nit:** Same as above — use `Collections.emptyList()` for consistency.
   
   ```suggestion
                   new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, Collections.emptyList())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to