arturobernalg opened a new pull request, #3592:
URL: https://github.com/apache/maven-surefire/pull/3592

   Fixes #2960
   
   Interpolating an expression like `${settings.offline}` into a 
`<systemPropertyVariables>` entry resolves to its real typed object (`Boolean` 
in this case), not a `String`. Because `setSystemPropertyVariables` is declared 
as `Map<String, String>`, the plugin configurator rejects the value outright 
before the mojo even runs:
   
   ```
   Cannot assign configuration entry 'isOffline' with value 
'${settings.offline}' of type java.lang.Boolean to property of type 
java.lang.String
   ```
   
   This was reported and reviewed favorably by a maintainer in #340 back in 
2019 (only style nits were raised), but the author lost time to work on it and 
closed it unmerged. This PR applies the same approach: widen the setter to 
`Map<String, ?>` so the configurator stops enforcing the String-only type, then 
stringify every value explicitly.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to