gnodet-bot commented on code in PR #13930:
URL: https://github.com/apache/maven/pull/13930#discussion_r4558198200


##########
impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanCreatorTest.java:
##########
@@ -227,8 +227,7 @@ private void assertIsSuccessor(BuildStep predecessor, 
BuildStep successor) {
     @SuppressWarnings("checkstyle:UnusedLocalVariable")
     private BuildPlan calculateLifecycleMappings(Map<MavenProject, 
List<MavenProject>> projects, String phase) {
         DefaultLifecycleRegistry lifecycles = new 
DefaultLifecycleRegistry(Collections.emptyList());
-        BuildPlanExecutor builder = new BuildPlanExecutor(
-                null, null, null, null, null, null, null, null, lifecycles, 
Collections.emptyList());
+        BuildPlanExecutor builder = new BuildPlanExecutor(null, null, null, 
null, null, null, null, null, lifecycles);
         BuildPlanExecutor.BuildContext context = builder.new BuildContext();
         return context.calculateLifecycleMappings(projects, phase);

Review Comment:
   ⚠️ **Regression — missing 10th constructor argument (CI failing)**
   
   This commit removes `Collections.emptyList()` (the `lifecycleProcessors` 
parameter added by #13962). `BuildPlanExecutor` requires 10 arguments — this 
causes a compile error and a Spotless formatting violation (single-line format 
doesn't match master's multi-line).
   
   Restore to match master:
   
   ```suggestion
                   null, null, null, null, null, null, null, null, lifecycles, 
Collections.emptyList());
   ```



##########
impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanCreatorTest.java:
##########
@@ -502,8 +501,7 @@ void testReactorPluginPreCompilePhase() {
         // "initialize" ends well before "ready" in the lifecycle.
         DefaultLifecycleRegistry lifecycles = new 
DefaultLifecycleRegistry(Collections.emptyList());
         BuildPlanExecutor.BuildContext context =

Review Comment:
   ⚠️ Same issue — missing `null` as the 10th `lifecycleProcessors` argument:
   
   ```suggestion
                   new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, null)
   ```



##########
impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanCreatorTest.java:
##########
@@ -584,8 +582,7 @@ void 
testReactorPluginWithLibraryDependencyPreCompilePhase() {
 
         DefaultLifecycleRegistry lifecycles = new 
DefaultLifecycleRegistry(Collections.emptyList());
         BuildPlanExecutor.BuildContext context =
-                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, null)
-                .new BuildContext();
+                new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles).new BuildContext();

Review Comment:
   ⚠️ Same issue — missing `null` as the 10th `lifecycleProcessors` argument:
   
   ```suggestion
                   new BuildPlanExecutor(null, null, null, null, null, null, 
null, null, lifecycles, null)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to