gnodet-bot commented on code in PR #13922:
URL: https://github.com/apache/maven/pull/13922#discussion_r4562073952


##########
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5530MojoExecutionScopeTest.java:
##########
@@ -37,6 +37,7 @@ public void testCopyfiles() throws Exception {
 
         // install the test plugin
         verifier = newVerifier(pluginDir);
+        verifier.getSystemProperties().put("maven.compiler.release", "8");
         verifier.addCliArgument("install");

Review Comment:
   ⚠️ **Redundant override.** The mng-5530 fixture POMs were upgraded in the 
previous commit (`87e3a81`) to `sisu-maven-plugin:1.1.2` and 
`plexus-component-metadata:2.2.0`, which both support Java 17 class files. This 
`release=8` override is unnecessary — the fixture will compile fine at Java 17. 
Please remove it (and the three identical overrides in 
`testCopyfilesMultithreaded` and `testExtension`) and keep the fixture-POM 
upgrades as the solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to