gnodet opened a new pull request, #13990: URL: https://github.com/apache/maven/pull/13990
Backport of #13955 to `maven-4.0.x`. Port of #13924. Replace the 386-line `FastTerminal` proxy with JLine 4.7.0's built-in `TerminalBuilder.buildDeferred()`, which provides the same semantics with less code and better performance. **Changes:** - **Delete `FastTerminal.java`** — replaced by JLine's `DeferredTerminal` - **Simplify `MessageUtils.systemInstall()`** — uses `buildDeferred()` + `onComplete()` callback - **Move `createTerminal()` to the first step of `doInvoke()`** — terminal builds in background while validate/pushProperties/configureLogging run - **Handle embedded mode** — use raw streams for embedded mode to avoid StackOverflowError; `doConfigureWithTerminal` moved to main thread after configureLogging - **Fix `awaitTerminalInitialization`** to wait for the `onComplete` callback to fire - **Fix ANSI output** for dumb terminals and IT stdout verification; guard stdout fallback on size > 0 - **Skip waiting on shutdown** — if the terminal isn't ready when the process exits, `close()` drains buffered output to stdout - **Bump JLine from 4.5.0 to 4.7.0** - **Update `FastTerminalReentrancyTest`** to use `DeferredTerminal` and **re-enable `MavenCliLoggingTest`** **Net: -390 lines** (+71, -461) Cherry-picked from 6145dae0de2b5d63465fa08215804cc98c1b25f9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
