AmarGhugare opened a new pull request, #13993: URL: https://github.com/apache/maven/pull/13993
`PathSelector` can discard an explicit `glob:` exclusion while reducing the exclusion list. For example, including `foo/*.java` and excluding `glob:foo/Excluded.java` still selects `foo/Excluded.java`. The include fragments have their syntax prefix removed, but the exclusion is compared with its prefix intact. Strip the prefix from the temporary comparison string while retaining the original pattern for the filesystem matcher. Add regression coverage for explicit and implicit include syntax, literal and wildcard exclusions, and default exclusions enabled/disabled. Controls cover ordinary exclusions, regex exclusions, and omission of unrelated exclusions. Eight cases fail before the fix; all 20 `PathSelectorTest` cases pass afterward. ## Validation With JDK 17 and Maven 3.10.0: - `mvn -B -ntp -pl :maven-impl -am -Dtest=PathSelectorTest -Dsurefire.failIfNoSpecifiedTests=false test` passed across all 20 selected reactor modules, including Checkstyle, Spotless, and RAT checks. - The full `maven-impl` unit suite completed during `mvn -Prun-its verify`: 930 tests, zero failures/errors, four skips. - Full reactor/integration verification was attempted but did not complete locally. The default-heap run was stopped during the slow `ProjectBuilderTest.testDeepParentHierarchy`; a retry with a 1 GB test heap was interrupted before reaching the integration tests. --- - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
