gnodet-bot commented on code in PR #14002:
URL: https://github.com/apache/maven/pull/14002#discussion_r4574577573


##########
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1088ReactorPluginResolutionTest.java:
##########
@@ -20,42 +20,39 @@
 
 import java.io.File;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
  * This is a test set for <a 
href="https://issues.apache.org/jira/browse/MNG-1088";>MNG-1088</a>.
  *
- * @author Brett Porter
+ * <p>Verifies that the concurrent builder automatically builds a reactor 
plugin project up to
+ * the READY phase when another project in the reactor uses that plugin, even 
if the user
+ * requested a phase before "compile" (e.g. "initialize").
  *
+ * @author Brett Porter
  */
-@Disabled("Disabled for MNG-7977")
-public class MavenITmng1088ReactorPluginResolutionTest extends 
AbstractMavenIntegrationTestCase {
+class MavenITmng1088ReactorPluginResolutionTest extends 
AbstractMavenIntegrationTestCase {

Review Comment:
   ⚠️ **Missing constructor — will not compile on `maven-4.0.x`**
   
   The constructor calling `super(ALL_MAVEN_VERSIONS)` was removed here (see 
deleted lines above). On `maven-4.0.x`, `AbstractMavenIntegrationTestCase` only 
has constructors requiring a `String` versionRangeStr — no no-arg constructor 
exists (it was added in `be9541cb9d` on `master`, never backported). This class 
will fail to compile.
   
   Add back a constructor:
   ```suggestion
   class MavenITmng1088ReactorPluginResolutionTest extends 
AbstractMavenIntegrationTestCase {
   
       MavenITmng1088ReactorPluginResolutionTest() {
           super("(4.0.0-alpha-1,)");
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to