arturobernalg commented on code in PR #3589:
URL: https://github.com/apache/maven-surefire/pull/3589#discussion_r4574771490


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporterUtils.java:
##########
@@ -26,11 +26,27 @@
  * @author Andreas Gudian
  */
 public final class FileReporterUtils {
+    // well under the 255-byte limit most filesystems enforce per path 
component,
+    // leaving room for encodings that use more than one byte per character and
+    // for filesystems with a lower limit still (e.g. eCryptfs)
+    private static final int MAX_FILE_NAME_LENGTH = 200;

Review Comment:
   Right, doesn't cover eCryptfs. It works for the actual bug report (#2697): 
ext4 and NTFS, which both cap a path component at 255 bytes - that's what a 
deeply nested package + a long generated/parameterized test class name runs 
into. eCryptfs's own limit is much lower (143) because it inflates the 
encrypted name, so no fixed cutoff here covers it; that'd need its own 
handling, out of scope for this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to