gnodet-bot commented on code in PR #1276:
URL: 
https://github.com/apache/maven-plugin-tools/pull/1276#discussion_r4576009824


##########
maven-plugin-plugin/src/it/skip/pom.xml:
##########
@@ -42,6 +42,12 @@ under the License.
       <artifactId>maven-plugin-api</artifactId>
       <version>@maven3Version@</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.plugin-tools</groupId>
+      <artifactId>maven-plugin-annotations</artifactId>
+      <version>@project.version@</version>
+      <scope>compile</scope>

Review Comment:
   ⚠️ **Minor:** `maven-plugin-annotations` uses `compile` scope here, but 
`provided` is the convention throughout this PR (see `help-package/pom.xml` 
line 47 and the other three ITs). Annotation types carry no runtime behavior — 
`provided` is correct.
   
   ```suggestion
         <scope>provided</scope>
   ```



##########
maven-plugin-plugin/src/it/source-encoding/latin-1/pom.xml:
##########
@@ -43,6 +43,12 @@ under the License.
       <version>@maven3Version@</version>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.plugin-tools</groupId>
+      <artifactId>maven-plugin-annotations</artifactId>
+      <version>@project.version@</version>
+      <scope>compile</scope>

Review Comment:
   ⚠️ **Minor:** Same as `skip/pom.xml` — `compile` scope for 
`maven-plugin-annotations` should be `provided`.
   
   ```suggestion
         <scope>provided</scope>
   ```



##########
maven-plugin-report-plugin/src/it/fix-maven-since-3.x/javasample-maven-plugin/pom.xml:
##########
@@ -46,5 +46,11 @@
       <version>@maven3Version@</version>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.plugin-tools</groupId>
+      <artifactId>maven-plugin-annotations</artifactId>
+      <version>@project.version@</version>
+      <scope>compile</scope>

Review Comment:
   ⚠️ **Minor:** Same issue — `compile` scope for `maven-plugin-annotations`. 
The sibling `antsample-maven-plugin/pom.xml` in this same PR uses `provided`. 
Please align.
   
   ```suggestion
         <scope>provided</scope>
   ```



##########
maven-plugin-plugin/src/it/source-encoding/utf-8/pom.xml:
##########
@@ -43,6 +43,12 @@ under the License.
       <version>@maven3Version@</version>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.plugin-tools</groupId>
+      <artifactId>maven-plugin-annotations</artifactId>
+      <version>@project.version@</version>
+      <scope>compile</scope>

Review Comment:
   ⚠️ **Minor:** Same as `skip/pom.xml` — `compile` scope for 
`maven-plugin-annotations` should be `provided`.
   
   ```suggestion
         <scope>provided</scope>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to