arturobernalg opened a new pull request, #3600:
URL: https://github.com/apache/maven-surefire/pull/3600
…when the value is unchanged
SurefireProperties.putAllInternal() and copyProperties() flagged a key as
overwritten purely because it already existed in the target map, without
comparing the previous value to the new one. This made
calculateEffectiveProperties() log a misleading "System property overwritten by
user properties from Maven session" warning even when a <systemProperties>
entry is set to the same value as the matching user property, e.g. via a
placeholder such as <sha1>${sha1}</sha1> that Maven interpolates to the
-Dsha1=... value already on the CLI.
Claude-Session: https://claude.ai/code/session_01BrsHTdDq7PD1DoqeA9vs66
Fixes #2643. Both copy methods only checked whether the target map already
had an entry for the key, not whether the value actually changed, so
re-applying the same key/value pair (e.g. a <systemProperties> placeholder that
Maven interpolates to the same value as the matching -D user property) was
reported as an overwrite and triggered a spurious WARNING.
---
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](https://www.apache.org/licenses/LICENSE-2.0)
check one of the following:
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
- [x] I hereby declare that I have filed an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]