spannm opened a new pull request, #1808:
URL: https://github.com/apache/maven-dependency-plugin/pull/1808

   I'm glad my suggestion was implemented: `mvn dependency:tree -DshowSizes`. 
While trying it before the release I ran into two problems with the totals and 
one with the formatting.
   
   3d995d83 fixes the totals. The result for a node was cached while a cycle 
through omitted nodes was still open, so with p:1 -> q:1 (kept as q:2) and q:2 
-> p:2 (kept as p:1) the total of q missed what p brings in, depending on 
traversal order. Each node now collects its artifacts on its own. Also, an 
omitted node never found a timestamped snapshot as its winner, because the 
winner version is a base version while the key used the full version. Along the 
way the verbose tree now compares full versions to tell a duplicate from a 
conflict. The new tests fail on master.
   
   c511a126 formats sizes like Maven's transfer log: 1000-based units B, kB, MB 
and GB, one decimal below 10. Before, KB meant 1024 bytes, so a jar showed a 
different size in the tree than in "Downloaded ... (1.5 MB at ...)".
   
   Both touch only the unreleased feature, so they could go into 3.12.0 
together with it.
   
   ---
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to