gnodet commented on code in PR #13986:
URL: https://github.com/apache/maven/pull/13986#discussion_r4580649550


##########
pom.xml:
##########
@@ -858,8 +858,15 @@ under the License.
           <groupId>org.apache.rat</groupId>
           <artifactId>apache-rat-plugin</artifactId>
           <configuration>
+            <!-- Workaround for https://github.com/apache/creadur-rat/pull/773:
+                 The SCM ignore file discovery walk traverses ALL directories
+                 (including hidden ones like .claude/ and .worktrees/) without
+                 respecting exclusion patterns, causing RAT to hang when large
+                 git worktree trees exist under hidden directories. -->
+            <parseSCMIgnoresAsExcludes>false</parseSCMIgnoresAsExcludes>

Review Comment:
   Good catch —  is indeed deprecated in 0.18.
   
   Unfortunately, the new API can't directly replace it here:
   - / exclude **path matcher** actions from a StandardCollection but 
explicitly **do not** exclude **file processor** actions. The  traversal that 
causes the hang is a file processor action (), so this parameter has no effect 
on the traversal.
   -  lets you specify which SCM files to parse, but the problem is RAT's 
default () triggers the traversal unconditionally, and there's no 
non-deprecated parameter to fully disable that file processor walk.
   
   The deprecated  remains the only way to suppress the traversal in RAT 0.18. 
The upstream fix in 
[creadur-rat#773](https://github.com/apache/creadur-rat/pull/773) addresses the 
root cause (skipping hidden dirs during the walk), after which this whole 
workaround can be removed. I'll update the comment to acknowledge the 
deprecation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to