gnodet-bot commented on PR #14027: URL: https://github.com/apache/maven/pull/14027#issuecomment-6921448058
Additionally, the PR will fail to compile: `DefaultPluginPrefixResolverTest.java` was not updated to match the refactored constructor. The production code changes the constructor from 4 arguments to 2: ```java // New constructor (this PR) public DefaultPluginPrefixResolver(RepositorySystem repositorySystem, MetadataReader metadataReader) ``` But the test still instantiates with the old 4-argument signature and imports types that were removed: ```java // Still in the test (unchanged) import org.apache.maven.plugin.BuildPluginManager; import org.apache.maven.plugin.version.PluginVersionResolver; ... new DefaultPluginPrefixResolver(pluginManager, repositorySystem, metadataReader, pluginVersionResolver) ``` The test also exercises `resolveFromProject` logic (via `pluginManager.loadPlugin(...)`) that was deleted in this PR. This will cause a compilation failure — the test file must be updated or removed alongside the production change. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
