gnodet-bot commented on code in PR #14028:
URL: https://github.com/apache/maven/pull/14028#discussion_r4588132167
##########
impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedCompositeBeanHelper.java:
##########
@@ -301,9 +304,19 @@ private Object convertProperty(
* Set field value with cached accessibility.
*/
private void setFieldValue(Object bean, Field field, Object value) throws
IllegalAccessException {
- if (!field.canAccess(bean)) {
+ Boolean isAccessible = ACCESSIBLE_FIELD_CACHE.get(field);
+ if (isAccessible == null) {
+ isAccessible = field.canAccess(bean);
+ if (!isAccessible) {
+ field.setAccessible(true);
+ isAccessible = true;
+ }
+ ACCESSIBLE_FIELD_CACHE.put(field, isAccessible);
+ } else if (!isAccessible) {
field.setAccessible(true);
Review Comment:
🐛 **Dead code — unreachable branch:** The `else if (!isAccessible)` block
can never execute.
The cache only ever stores `Boolean.TRUE`: inside the `isAccessible == null`
branch, both sub-paths (`canAccess` returns `true`, or `canAccess` returns
`false` → `setAccessible(true)` → `isAccessible = true`) unconditionally set
`isAccessible = true` before `ACCESSIBLE_FIELD_CACHE.put(field, isAccessible)`.
So on a cache hit, `!isAccessible` is always `false`.
This block should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]