gnodet-bot commented on code in PR #2319:
URL: https://github.com/apache/maven-resolver/pull/2319#discussion_r4590489084
##########
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/io/PathProcessorSupport.java:
##########
@@ -357,6 +357,10 @@ protected boolean isClassicCopyFallbackEnabled() {
* Pre-NIO2 way to copy files. Opens the target with truncation; normally
callers stage into a temporary file and
* rename into place to avoid exposing partially written content. Used as
a last resort on Windows when all atomic
* rename attempts are exhausted due to a persistent file lock (see {@link
#retryingMove}).
+ * <p>
+ * The target gets the last modified time of the source,
+ * which the transports set from the remote "Last-Modified" header,
+ * as it does with a move.
Review Comment:
💡 Minor doc nit: "as it does with a move" has an ambiguous antecedent — "it"
could refer to the target, the source, or the method itself. Suggest rephrasing
for clarity:
```suggestion
* <p>
* The target receives the last modified time of the source,
* preserving the remote "Last-Modified" time that a rename keeps.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]