gnodet-bot commented on code in PR #14038:
URL: https://github.com/apache/maven/pull/14038#discussion_r4602201037


##########
compat/maven-resolver-provider/pom.xml:
##########
@@ -111,6 +111,7 @@ under the License.
       <groupId>org.slf4j</groupId>
       <artifactId>jcl-over-slf4j</artifactId>
       <scope>runtime</scope>
+      <optional>true</optional>
     </dependency>

Review Comment:
   ⚠️ **Incorrect fix**: The compat module source (`src/`) contains zero 
imports of `org.apache.commons.logging` — there is no JCL usage here. This 
dependency should be **removed entirely**, not made optional. Additionally, 
`apache-maven/pom.xml` independently declares `jcl-over-slf4j` as a direct 
`runtime` dependency, so the jar still ships in Maven's distribution regardless 
of this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to