slachiewicz opened a new pull request, #807:
URL: https://github.com/apache/maven-invoker-plugin/pull/807

   A selector made only of toolchain keys, such as 
`selector.1.invoker.toolchain.jdk.version = 17`, was ignored: 
`isSelectorDefined` checked only the Java, Maven and OS family keys, so the 
project ran on every JDK instead of being skipped when no matching toolchain 
exists. Toolchain keys now count as defining a selector, as the selector 
documentation describes.
   
   Verified: `mvn -P run-its verify` → 87 tests and 81 ITs pass; the new 
assertion in `InvokerPropertiesTest` fails without the fix.
   
   ---
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to