slachiewicz opened a new pull request, #188:
URL: https://github.com/apache/maven-reporting-exec/pull/188

   `org.codehaus.doxia.sink.Sink`, deprecated since Doxia 1.0-alpha-6, looks 
like dead code, but it is load-bearing: report plugins that still declare the 
Maven 2 era `generate(org.codehaus.doxia.sink.Sink, Locale)` need it to load 
during `mvn site`. With it removed, a site build with the JaCoCo report fails:
   
   ```text
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.22.0:site (default-site) on 
project jacoco-site: Execution default-site of goal 
org.apache.maven.plugins:maven-site-plugin:3.22.0:site failed: A required class 
was missing while executing 
org.apache.maven.plugins:maven-site-plugin:3.22.0:site: 
org/codehaus/doxia/sink/Sink
   ```
   
   This adds the reason to the class Javadoc and a test that references the 
type, so a deprecation cleanup cannot delete it unnoticed.
   
   Verified: jacoco-maven-plugin 0.8.16 `report` under maven-site-plugin 3.22.0 
→ fails with this reporting-exec built without the class, passes with 2.0.1; 
`mvn verify` → 6 tests and 5 ITs pass.
   
   ---
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to