arturobernalg opened a new pull request, #905:
URL: https://github.com/apache/maven-shade-plugin/pull/905

   #709 (MSHADE-451): with `shadedArtifactAttached=true`, 
`shadedArtifactFileWithClassifier()` (and its classifier overload, used for the 
sources/test/test-sources variants) always built the attached jar's name from 
`shadedArtifactId + version`, ignoring a customized `<build><finalName>`. Its 
sibling `shadedArtifactFile(String)`, used when the shaded jar replaces the 
original artifact instead, already checks `project.getBuild().getFinalName()` 
first. So with a custom finalName and `shadedClassifierName=foo`, the attached 
jar came out named `artifactId-version-foo.jar` instead of `finalName-foo.jar`, 
inconsistent with every other artifact the build produces.
   
   Made both methods consult `finalName` the same way their sibling already 
does.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [ ] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   https://claude.ai/code/session_01BrsHTdDq7PD1DoqeA9vs66


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to