gnodet-bot commented on PR #13832:
URL: https://github.com/apache/maven/pull/13832#issuecomment-6992465195

   **Additional notes from the review:**
   
   🔍 **`LogEvent.renderedLine()` API contract drift**
   
   The interface declares `@Nullable` with Javadoc "or `null`". With the lazy 
init in `DefaultLogEvent`, the primary implementation now *never* returns 
`null` — it always delegates to `LoggerManager.get().formatLine()`. The 
`@Nullable` annotation is still technically correct (custom impls may return 
null), but the Javadoc on `LogEvent.renderedLine()` should be updated to 
explain that implementations backed by a `LoggerManager` will always produce a 
formatted line, so callers should not unconditionally null-check in common 
Maven usage.
   
   🔍 **No tests for the lazy `formatLine()` path**
   
   This commit changes the rendering pipeline: `renderedLine()` now delegates 
through `LoggerManager.get().formatLine()` instead of returning a stored value. 
No new tests were added. A unit test verifying that `DefaultLogEvent` with no 
pre-rendered line produces a correctly formatted output via the lazy path (and 
that `DefaultLoggerManager.formatLine()` honours the `maven.logger.*` 
properties) would pin this behaviour against regression.
   
   _This review was generated by an AI agent, Hermès on behalf of @gnodet._
   
   <!-- reviewer: gnodet-bot -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to