slachiewicz opened a new pull request, #234: URL: https://github.com/apache/maven-script-interpreter/pull/234
The `failedGroovyShouldCreateProperLogsMessage` test caught `ScriptEvaluationException` but still passed when no exception was thrown, so it did not actually verify the failure path. - Wrap the `scriptRunner.run(...)` call in `assertThrows(ScriptEvaluationException.class, ...)` and keep both log assertions after it. - Replace `assertEquals(false, ...)` with `assertFalse(...)` for the returned result, casting to `Boolean` because `getResult()` returns `Object`. - No change to the number of test cases (18 in `ScriptRunnerTest`, 36 in the module). Tracking: #14072 Verified: `JAVA_HOME=<JDK 21> mvn -B -o test` → 36 tests, 0 failures/errors, BUILD SUCCESS (0 Checkstyle violations). Mutation: making `ScriptRunner.run` return normally for the `failed` fixture makes this test fail with "Expected ScriptEvaluationException to be thrown, but nothing was thrown"; the scratch change was restored and the suite re-run green. CI not checked here (driver checks centrally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
