slachiewicz opened a new pull request, #461:
URL: https://github.com/apache/maven-shared-utils/pull/461

   Several test classes still use the JUnit 3 idiom of `public void testXxx()` 
methods; JUnit 5 discovers tests by annotation, so the `public` modifier and 
the `test` prefix are no longer needed.
   
   Changes:
   - Renamed 258 `@Test` methods named `testXxx` to descriptive lowerCamelCase 
names across 13 test classes (for example `testGetRelativePath2Parm` to 
`getRelativePath2Parm`, `testMalformedXml` to `malformedXml`).
   - Dropped `public` from those test methods and from the 13 enclosing test 
classes; removed the two now-redundant `public` constructors in 
`ReflectionValueExtractorTest` nested fixtures.
   - Left helpers, `@BeforeEach` setup methods and already-descriptive `@Test` 
methods untouched; skipped `MessageUtilsTest` and `PrettyPrintXmlWriterTest` 
because open PRs #451 and #391 touch them.
   - Updated two `PathToolTest` comments that referenced renamed methods.
   
   Tracking: apache/maven#14072
   Verified: 
`JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B 
-o test` → BUILD SUCCESS, 804 tests / 0 failures / 0 errors / 19 skipped; 
per-class surefire `tests=` identical before and after for all 25 classes (804 
total). Mutation check on renamed `PathToolTest.uppercaseDrive` failed as 
expected (`expected: <MUTATED:> but was: <D:>`), then the file was restored 
from the saved copy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to