olamy opened a new pull request, #3607: URL: https://github.com/apache/maven-surefire/pull/3607
Fixes #3366 On Windows, `CommandlineExecutorTest.shouldExecuteNativeCommand` runs `cmd.exe /c dir`. On a German machine the first line of that output is ` Datenträger in Laufwerk D: ist ...`, written in the console code page (Cp850 or Cp1252). `LineConsumerThread` decodes with `Charset.defaultCharset()`, which is UTF-8 since JDK 18, so the `ä` is malformed input. `Scanner` treats the decode error as end of input and the handler never gets a line, hence "zero interactions with this mock". The test now runs `dir /b`, which prints only the file names, so there's no localized header to trip over. English Windows never hit this because its `dir` output is plain ASCII. This is separate from #3603 (the `wait()` loop in `CountdownCloseable`), which doesn't fix this one. Signed-off-by: Olivier Lamy <[email protected]> --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
