slachiewicz opened a new pull request, #1286: URL: https://github.com/apache/maven-plugin-tools/pull/1286
Migrate the javadoc-site HTTP client from HttpComponents 4.x to 5.x. ## What changed - `maven-plugin-tools-api/pom.xml`: replace `org.apache.httpcomponents:httpclient` 4.5.14 and `httpcore` 4.4.16 with `httpclient5` 5.6.1 and `httpcore5` 5.4.2 (latest stable 5.x releases). `httpcore5-h2` 5.4 arrives transitively from the client. - `JavadocSite`: switch to the `org.apache.hc.client5.*` / `org.apache.hc.core5.*` APIs — `RequestConfig.setResponseTimeout(timeout, MILLISECONDS)`, `StandardCookieSpec.IGNORE`, `UsernamePasswordCredentials(char[])`, `CredentialsStore`, `new AuthScope(null, -1)`, `ClassicHttpResponse.getCode()`, `HttpClientContext.getRedirectLocations().getAll()` and `HttpGet.reset()`. ## Why 4.5.14 / 4.4.16 are the final 4.x releases and no longer receive fixes. This keeps retrieval of `package-list` / `element-list` from existing javadoc sites on a maintained stack. The change is based on the earlier `http5` migration work, rebased onto the current `maven-plugin-tools-3.x` head. ## Verification - `JAVA_HOME=.../17.0.20-amzn mvn -q -B -N spotless:check` — passed. - `JAVA_HOME=.../17.0.20-amzn mvn -q -B -pl maven-plugin-tools-api test` — 61 tests, 0 failures, 0 errors, 0 skipped. ## Risk - No HttpComponents type appears in a public or protected signature of `JavadocSite`, so the dependency is internal to the API module; no consumer-visible API change. - Proxy credentials are now passed as `char[]` and the wildcard scope is expressed as `new AuthScope(null, -1)` because `AuthScope.ANY` does not exist in 5.x; proxy behaviour is otherwise unchanged. - `HttpGet.reset()` replaces `releaseConnection()`; the enclosing reader and client are still closed as before. Draft pending CI. The forward-port to `master` is prepared as a separate, sequential PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
