dhananjay6561 opened a new pull request, #3609:
URL: https://github.com/apache/maven-surefire/pull/3609

   Fixes #2224.
   
   The inclusion/exclusion page shows patterns like `**/TestCircle.java`, which 
work because a trailing `.java` is rewritten to `.class` before matching 
(`ResolvedTest.convertToPath`). That rewrite only covers `.java`. Users with 
Groovy or Kotlin tests naturally write `**/RunBackendTest.groovy`, and that 
pattern silently matches nothing, which is exactly what the issue reports.
   
   This adds a short note under the Exclusions example saying that patterns are 
matched against compiled `.class` files, that `.java` is translated, and that 
other source extensions are not, so the extension should be left off or written 
as `.class`.
   
   I checked the current behaviour against `ResolvedTest` on master before 
writing the note. For the class file `pkg/RunBackendTest.class`:
   
   | pattern | matches |
   |---|---|
   | `**/RunBackendTest.groovy` | no |
   | `**/FooSpec.kt` style (`.kt`) | no |
   | `**/RunBackendTest.java` | yes |
   | `**/RunBackendTest` | yes |
   | `**/RunBackendTest.class` | yes |
   
   Docs only, no code change.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [ ] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to