gnodet commented on PR #14066:
URL: https://github.com/apache/maven/pull/14066#issuecomment-7039909696

   Thanks @slachiewicz — all four points have been addressed in the commits 
after `be56e7d4ec` (which your review was based on):
   
   1. **`withProjectId`/`withMojoId` no-ops + `LogContext` reference** — the 
bogus `LogContext` description has been removed from both `Logger.java` and 
`LogEventBuilder.java`. Both methods now document the best-effort semantics: 
"enrichment is implementation-defined; implementations may silently ignore the 
value." (commits `b8f566bf` and `f93003af`)
   
   2. **`Logger.atLevel()` typo in `package-info.java`** — fixed to 
`Logger.at(LogLevel)` in commit `b5de15ee`.
   
   3. **`ModelProcessor.read(Source, Map)` options handling** — the bridge now 
reads the `strict` key from the options map (`options.get(ModelParser.STRICT)`) 
and only falls back to `true` when the key is absent. It no longer hardcodes 
`strict(true)`. (commit `f93003af`)
   
   4. **Test coverage** — `DefaultLoggerTest` now covers: fluent builder with 
key-value pairs, NOP builder laziness (supplier not invoked when disabled), NOP 
builder `assertSame` chaining, `withThrowable` after and before key-value 
calls, and the `ModelProcessor` bridge for both `null` options (strict=true) 
and explicit `"false"` (strict=false). (commits `f93003af` and `93ca4961`)
   
   _— Hermès on behalf of @gnodet_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to