slachiewicz opened a new pull request, #485:
URL: https://github.com/apache/maven-wrapper/pull/485

   `testCreateDist()` in `InstallerTest` has no JUnit annotation, so it is 
never executed; if it were annotated it would fail because it never calls 
`createTestZip(zipDestination)`. The annotated 
`testCreateDistWithExistingDistribution()` covers the working path.
   
   Changes:
   - Deleted the dead unannotated `testCreateDist()` method only.
   - Kept `testCreateDistWithExistingDistribution()` and all other tests 
untouched.
   
   Stacked on #398; branch contains the blocker's commits. Rebase after the 
blocker merges.
   Blocker credit: PR #398 by @erik-meuwese-topicus ("MWRAPPER-117 - added 
distributionSha512Sum and wrapperSha512Sum for verification with SHA-512..."). 
Base: master.
   
   Tracking: apache/maven#14072
   Verified: `JAVA_HOME=.../zulu-21.jdk/Contents/Home mvn -B -o test` -> BUILD 
SUCCESS; InstallerTest 4 tests (unchanged - the removed method was never 
executed), wrapper module 32 + plugin module 4 = 36 tests, 0 failures/errors. 
One-time online run used to resolve a missing `apache-jar-resource-bundle:1.7` 
into the local repository before the offline verification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to