slachiewicz opened a new pull request, #1457: URL: https://github.com/apache/maven-scm/pull/1457
Replace behavior-identical `size() > 0` checks with `!isEmpty()` in the seven provider/API classes from the sweep (HgScmProvider, AbstractSvnScmProvider, AbstractGitScmProvider, AbstractUpdateCommand, GitCheckOutCommand, JGitCheckOutCommand, JGitCheckInCommand). No other occurrences were changed. Tracking: apache/maven#14072 Verified: `JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o test` — the gitexe module has the same single pre-existing environment-dependent failure as baseline (`GitCheckInCommandTest#testSignedCheckin`, GPG; 83 tests, 1 failure, 1 skipped). With an isolated git/GPG home for forked tests and that one GPG test excluded, full 20-module reactor BUILD SUCCESS: 463 tests, 0 failures, 0 errors, 10 skipped (API 33, Hg 20, Git common 30, gitexe 126, JGit 62, SVN common 44, SVN exe 98, Local 20, Plugin 24, Test 6). Every per-module count is identical to baseline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
