slachiewicz opened a new issue, #3615: URL: https://github.com/apache/maven-surefire/issues/3615
Affected version: master at d7c7e359e. `TestSuiteXmlParser.parse(InputStreamReader)` (surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:79-101) creates a plain `SAXParserFactory.newInstance()` / `newSAXParser()` at lines 81-83 and parses the `InputSource` at line 90 without setting any secure-processing feature, DOCTYPE restriction, or external-access property. A repository-wide grep found no use of `FEATURE_SECURE_PROCESSING`, `disallow-doctype-decl`, `external-general-entities`, or `ACCESS_EXTERNAL_*` in any Java source. This parser is used both by the report plugin (`SurefireReportParser.parseXMLReportFiles`, lines 53-76) and by `LastFailedTestsResolver.readReports` (maven-surefire-common/.../lastfailed/LastFailedTestsResolver.java:223-239). Expected behavior: enable secure processing and disable DOCTYPE declarations and external entities at the parser factory. A regression test can supply a report with a DOCTYPE and assert that no external reference is resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
