slachiewicz opened a new pull request, #2341:
URL: https://github.com/apache/maven-resolver/pull/2341

   Forward-ports the `DirectoryUtilsTest` fix from the 1.9.x JUnit 5 migration 
(#2338). The eight `assertEquals` calls had expected and actual swapped, and 
the last check of `notExistsAndIsCreated` was an assumption, so a missing 
directory skipped the test instead of failing it.
   
   `notExistsAndIsCreated` also created the directory before calling 
`resolveDirectory(..., true)`, so it never tested the creation; it now starts 
without it and fails if `mayCreate` stops creating. That part is not on 1.9.x 
yet and will be backported. The last commit uses the existing static import of 
`fail` in `FileTransporterTest`.
   
   Verified: disabling `Files.createDirectories` in `DirectoryUtils` → 
`notExistsAndIsCreated` fails.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to