arturobernalg opened a new pull request, #1453:
URL: https://github.com/apache/maven-javadoc-plugin/pull/1453

   …ngs too
   
   javadoc:aggregate decides which reactor modules to fold in by calling 
isSkippedJavadoc() on each sibling MavenProject, which only read 
mavenProject.getProperties() - the raw POM/profile property map, not the 
resolved parameter value. A module's own javadoc execution honors a 
command-line -Dmaven.javadoc.skip=... override correctly, but a profile setting 
the property to true on every module defeated that override when the aggregate 
goal decided whether to pull a sibling in, so the aggregate came out empty even 
though each submodule's own javadoc was generated fine. Check 
session.getUserProperties() first, the same source Maven itself consults for 
the plugin's own @Parameter(property = "maven.javadoc.skip").
   
   
   Fixes #1003.
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to