slachiewicz opened a new pull request, #499:
URL: https://github.com/apache/maven-install-plugin/pull/499

   Part of #497. Companion to #498 on the 3.x line. This branch remains Maven 4 
only.
   
   Converts ten deterministic integration tests to JUnit 5 unit tests and 
removes the corresponding IT directories. Invalid/missing GAV messages, missing 
main artifact with attachments (both `target/classes` variants), POM 
auto-generation and non-overwrite, attached-artifact/POM checksum absence, and 
local-repository override with and without generated POM are all covered 
in-process with the Maven 4 `SessionMock` harness. `skip-install` was an exact 
duplicate of the existing `InstallMojoTest.skip()` and was removed without a 
new test.
   
   The remaining JIRA-keyed IT directories are renamed to describe what they 
test:
   `MINSTALL-108` → `install-at-end-default`, `MINSTALL-52` → 
`install-file-embedded-pom`, `MINSTALL-87` → `install-file-missing-file`, 
`MINSTALL-98` → `parallel-reactor-install`, `MINSTALL-99` → 
`per-project-config`, `minstall-55` → `install-file-generated-pom`, 
`MINSTALL-205` → `install-file-parallel`, `MINSTALL-206` → 
`install-at-end-phase-and-skip`.
   
   Unit tests went from 35 to 45; all pass. No Plexus Utils was added, and the 
one setup script touched now uses Groovy's `File.deleteDir()`. Reactor, `-T2`, 
`-f`, CLI `install-file` and version-specific ITs remain in place. No 
production code changed.
   
   Verification (JDK 21, Maven 4.0.0-rc-7): `mvn -o -B test` → 45/45 green; 
`mvn -o -B -Prun-its verify -Dinvoker.test=<renamed ITs>` → 8 ITs passed, 0 
failed; `mvn -o -B spotless:check` → success.
   
   Two follow-ups for the sync pass after both branches land: unit-test case 
names differ from #498, and `maven-metadata-local.xml` file-existence 
assertions cannot be reproduced with this branch's mocked `ArtifactInstaller` 
(the 3.x harness writes real files). The mojo contract — exact artifact set in 
the install request, generated POM GAV, source-file existence, override 
repository path — is asserted here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to