slachiewicz opened a new pull request, #500: URL: https://github.com/apache/maven-install-plugin/pull/500
Part of #497. Follow-up to #498 and #499, which have both landed. Sync pass on the 3.x line, keeping `maven-install-plugin-4.x` Maven 4 only: - The eleven case names introduced by the IT-to-unit migration now match the 4.x names (`invalidGavRejectedAndNothingInstalled`, `generatePomAutoInstallsJarAndPom`, `noMainArtifactWithAttachmentsFailsWhenOutputDirMissing`, `skip`, `attachedJarInstalledWithoutChecksums`, and so on). - Backported the `InstallTestHelper` utility from 4.x. It holds both the whole-repository `assertNoChecksumFiles(Path)` and the existing per-file `assertNoChecksum(File, String)`, replacing the two local copies in `InstallFileMojoTest` and `InstallMojoTest`. No test assertions, IT names or production code changed. Verification (JDK 21, Maven 3.9.16): `mvn -o -B test spotless:check` → 38/38 green, 0 Checkstyle violations. The one deliberate remaining difference: 4.x's `SessionMock` mocks `ArtifactInstaller`, so `maven-metadata-local.xml` file-existence assertions are expressed there as install-request assertions, while this branch's harness writes real files. That is a harness difference, not a behavioural one, and forcing it would weaken either branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
