elharo commented on code in PR #1438:
URL: https://github.com/apache/maven-scm/pull/1438#discussion_r4652985943
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java:
##########
@@ -346,8 +346,10 @@ private String parseUserInfo(RepositoryUrl repoUrl, String
url) throws ScmExcept
return url;
}
// extract user information, broken see SCM-907
- int indexAt = url.lastIndexOf('@');
- if (indexAt >= 0) {
+ // user info is only part of the authority, which ends at the first
slash
Review Comment:
I need to pull out the specs but I think raw C:\ file paths aren't URLs.
[email protected]:olamy/x.git might parse
but is this in fact a URL that we're passing in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]